-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PyNVML 12 #1419
Use PyNVML 12 #1419
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
/ok to test |
As cuDF is a test dependency ( rapidsai/cudf#17627 ), we still pick up PyNVML 11 in some places Think we will need to get one of these PRs in first (perhaps this one?) then come back and retest once cuDF is also built |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not strictly related to this PR's changes, but they'd help us build confidence in this and future pynvml
-related changes... since pynvml
is a hard runtime dependency, could we switch to using it unconditionally in tests, by removing stuff like this?
dask-cuda/dask_cuda/tests/test_utils.py
Line 200 in fd8a736
pynvml = pytest.importorskip("pynvml") |
dask-cuda/dask_cuda/tests/test_utils.py
Line 253 in fd8a736
pynvml = pytest.importorskip("pynvml") |
Think those skips could potentially cover up some packaging issues. I'd support trying to remove those right here in this PR, but also fine if you want to do it as a follow-up.
I agree that's sensible. @jakirkham do you want to address this in this PR or would you prefer I do that in a separate PR? |
As discussed offline, this is being handled in PR: #1421 |
Thanks James and Peter! 🙏 Looks like it is passing. Let's get this in |
/merge |
Bump `pynvml` from `11` to `12`. This version of `pynvml` also now depends on `nvidia-ml-py` for core functionality. Depends on PR: rapidsai/dask-cuda#1419 Authors: - https://github.com/jakirkham Approvers: - Peter Andreas Entschev (https://github.com/pentschev) - Ray Douglass (https://github.com/raydouglass) URL: #17627
Bump
pynvml
from11
to12
. This version ofpynvml
also now depends onnvidia-ml-py
for core functionality.