Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PyNVML 12 #1419

Merged
merged 3 commits into from
Dec 21, 2024
Merged

Use PyNVML 12 #1419

merged 3 commits into from
Dec 21, 2024

Conversation

jakirkham
Copy link
Member

Bump pynvml from 11 to 12. This version of pynvml also now depends on nvidia-ml-py for core functionality.

Copy link

copy-pr-bot bot commented Dec 19, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added the conda conda issue label Dec 19, 2024
@jakirkham jakirkham added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 19, 2024
@jakirkham jakirkham requested a review from rjzamora December 19, 2024 04:19
@jakirkham
Copy link
Member Author

/ok to test

@jakirkham jakirkham mentioned this pull request Dec 19, 2024
3 tasks
@jakirkham
Copy link
Member Author

As cuDF is a test dependency ( rapidsai/cudf#17627 ), we still pick up PyNVML 11 in some places

Think we will need to get one of these PRs in first (perhaps this one?) then come back and retest once cuDF is also built

@jakirkham jakirkham marked this pull request as ready for review December 20, 2024 07:34
@jakirkham jakirkham requested a review from a team as a code owner December 20, 2024 07:34
@jakirkham jakirkham requested a review from gforsyth December 20, 2024 07:34
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly related to this PR's changes, but they'd help us build confidence in this and future pynvml-related changes... since pynvml is a hard runtime dependency, could we switch to using it unconditionally in tests, by removing stuff like this?

pynvml = pytest.importorskip("pynvml")

pynvml = pytest.importorskip("pynvml")

Think those skips could potentially cover up some packaging issues. I'd support trying to remove those right here in this PR, but also fine if you want to do it as a follow-up.

@pentschev
Copy link
Member

Not strictly related to this PR's changes, but they'd help us build confidence in this and future pynvml-related changes... since pynvml is a hard runtime dependency, could we switch to using it unconditionally in tests, by removing stuff like this?

I agree that's sensible. @jakirkham do you want to address this in this PR or would you prefer I do that in a separate PR?

@jakirkham
Copy link
Member Author

As discussed offline, this is being handled in PR: #1421

@jakirkham
Copy link
Member Author

Thanks James and Peter! 🙏

Looks like it is passing. Let's get this in :shipit:

@jakirkham
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit d9c6996 into rapidsai:branch-25.02 Dec 21, 2024
27 checks passed
@jakirkham jakirkham deleted the use_pynvml_12 branch December 21, 2024 00:29
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this pull request Dec 23, 2024
Bump `pynvml` from `11` to `12`. This version of `pynvml` also now depends on `nvidia-ml-py` for core functionality.

Depends on PR: rapidsai/dask-cuda#1419

Authors:
  - https://github.com/jakirkham

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)
  - Ray Douglass (https://github.com/raydouglass)

URL: #17627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda conda issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants